Remove Ads Conversion ID from Analytics and migrate setting.#12394
Remove Ads Conversion ID from Analytics and migrate setting.#12394
Conversation
📚 Storybook for 098b036: 📦 Build files for 098b036:
🎭 Playwright reports for 098b036: |
|
Size Change: 0 B Total Size: 2.31 MB ℹ️ View Unchanged
|
eugene-manuilov
left a comment
eugene-manuilov
left a comment
There was a problem hiding this comment.
Thanks, @tofumatt. There is some more work to do here.
There was a problem hiding this comment.
I know this has been added to IB, but we don't need this migration. There is nothing to migrate here. Let's remove this class.
There was a problem hiding this comment.
We've previously removed unneeded/unused keys from settings with other migrations; wouldn't it make sense to remove it now that it's no longer in use? It's not strictly needed but seems like good housekeeping 🤔
There was a problem hiding this comment.
Same here, not needed.
| return array( | ||
| 'ownerID' => 0, | ||
| 'accountID' => '', | ||
| 'adsConversionID' => '', |
There was a problem hiding this comment.
I believe we also need to delete this one, right?
There was a problem hiding this comment.
I thought this at first, but the ACs explicitly state not to mention it, because there's an older migration that relies on this key Migration_1_129_0.
It's removed from usage in the front-end but kept here for the migration.
We could extend the get() method to accept an argument that includes "legacy" keys and modify the old migration to use a modified get( array( 'include_legacy_keys' => true) ) call or something like that if you want to remove it from here?
| 'webDataStreamID' => '', | ||
| 'measurementID' => '', | ||
| 'ownerID' => 0, | ||
| 'adsConversionID' => '', |
There was a problem hiding this comment.
This should also be removed. There are more occurrences in this file.
| $this->assertEqualSetsWithIndex( | ||
| array( | ||
| 'accountID' => '', | ||
| 'adsConversionID' => '', |
There was a problem hiding this comment.
Should also be deleted.
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
The ACs explicitly state the 'adsConversionID' key should stick around, so I didn't remove it to meet the ACs.
I can remove the new migration if desired but to remove the 'adsConversionID' key I'll need to modify the old migration as well—let me know if you'd like that, but in that case we need to adjust the ACs.
3 participants
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist